[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus updated this revision to Diff 177189.
Szelethus added a comment.

- Register the checker after it's dependencies (accidentally left this change in the next branch). This implies that `unix.MallocChecker:Optimistic` is no longer a thing, and is now called ųnix.DynamicMemoryModeling:Optimistic`. This //could// break backward compatibility, but is also addressable, since it can always be converted to whatever full name `DynamicMemoryModeling` will have in the future. @george.karpenkov @NoQ feelings on this?
- In `test/Analysis/Inputs/expected-plists/nullability-notes.m.plist`, the name of the checker associated with a report changed, but this is **NOT** an issue raised by this patch -- simply changing the order of `analyzer-checker=ABC,CBA` to `CBA,ABC` will cause the same issue. Please don't mind me, but I'm not immediately interested in fixing this issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54438/new/

https://reviews.llvm.org/D54438

Files:
  include/clang/StaticAnalyzer/Checkers/CheckerBase.td
  include/clang/StaticAnalyzer/Checkers/Checkers.td
  include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h
  lib/StaticAnalyzer/Checkers/CStringChecker.cpp
  lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp
  lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp
  lib/StaticAnalyzer/Checkers/InterCheckerAPI.h
  lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
  lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
  lib/StaticAnalyzer/Checkers/MallocChecker.cpp
  lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
  lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp
  lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp
  lib/StaticAnalyzer/Checkers/ValistChecker.cpp
  lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp
  test/Analysis/Inputs/expected-plists/nullability-notes.m.plist
  test/Analysis/NewDelete+MismatchedDeallocator_intersections.cpp
  test/Analysis/NewDelete-checker-test.cpp
  test/Analysis/malloc-annotations.c
  utils/TableGen/ClangSACheckersEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54438.177189.patch
Type: text/x-patch
Size: 49807 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181207/9a8ea76a/attachment-0001.bin>