[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

[Carey Williams via Phabricator via cfe-commits]

carwil created this revision.
carwil added a project: clang.
Herald added a subscriber: cfe-commits.

Improve the description of these command line options by providing specific heuristic information, as outlined for the ssp function attribute(s) in LLVM's documentation.


Repository:
  rC Clang

https://reviews.llvm.org/D55428

Files:
  docs/ClangCommandLineReference.rst


Index: docs/ClangCommandLineReference.rst
===================================================================
--- docs/ClangCommandLineReference.rst
+++ docs/ClangCommandLineReference.rst
@@ -1870,7 +1870,7 @@
 
 .. option:: -fstack-protector, -fno-stack-protector
 
-Enable stack protectors for functions potentially vulnerable to stack smashing
+Enable stack protectors for some functions potentially vulnerable to stack smashing. Namely those containing a char (or 8bit integer) array or constant sized calls to alloca, which are of greater size than ssp-buffer-size (default: 8 bytes). All variable sized calls to alloca are considered vulnerable
 
 .. option:: -fstack-protector-all
 
@@ -1878,7 +1878,7 @@
 
 .. option:: -fstack-protector-strong
 
-Use a strong heuristic to apply stack protectors to functions
+Uses a stronger heuristic to apply stack protectors to functions that include arrays of any size (and any type), as well as any calls to alloca or the taking of an address from a local variable
 
 .. option:: -fstack-size-section, -fno-stack-size-section
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55428.177186.patch
Type: text/x-patch
Size: 1075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181207/c859a709/attachment-0001.bin>