[PATCH] D55394: Re-order type param children of ObjC nodes

Fri Dec 7 05:01:42 PST 2018

aaron.ballman added reviewers: ABataev, rsmith.
aaron.ballman added a comment.

I don't know enough about ObjC to feel comfortable saying whether this is a reasonable reordering or not, so adding some reviewers.

================
Comment at: test/AST/ast-dump-decl.m:90
 // CHECK-NEXT:   -ObjCProtocol {{.+}} 'P'
+// CHECK-NEXT:   -ObjCTypeParamDecl {{.+}} <col:33> col:33 T 'id':'id'

----------------
It seems strange to me to print out the type parameter after the superclass information given the source order. My understanding of the AST dumping order is that we try to keep the order of nodes in source order whenever possible.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55394/new/

https://reviews.llvm.org/D55394