[PATCH] D55083: Re-arrange content in FunctionDecl dump

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: test/AST/ast-dump-decl.cpp:217
 // CHECK-NEXT:     ParmVarDecl
+// CHECK-NEXT:     TemplateArgument
 // CHECK-NEXT:     CompoundStmt
----------------
I find this ordering to be confusing, especially because the template argument information is used by the parameter declaration type.


================
Comment at: test/AST/ast-dump-funcs.cpp:59
   // CHECK: CXXMethodDecl 0x{{[^ ]*}} <line:[[@LINE-1]]:3, col:28> col:8 f 'void (float, int)'
+  // CHECK-NEXT: Overrides: [ 0x{{[^ ]*}} S::f 'void (float, int)' ]
   // CHECK-NEXT: ParmVarDecl 0x{{[^ ]*}} <col:10> col:15 'float'
----------------
I don't think this belongs at the start of the function -- the parameter information seems far more interesting than what the method overrides.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55083/new/

https://reviews.llvm.org/D55083