[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 6 15:39:54 PST 2018


thakis added a comment.

The usual process for adding / tweaking warnings is to build some large open-source project with the new / tweaked warning and note true and false positive rate. IIRC I did this on Chromium when I added the warning, and the out-of-bounds check prevented false positives without removing true positives. (...or maybe Richard asked for it during review? Did you try and find the review where this got added?)

That is, can you try building Chromium with this tweak and see what it does to true and false positive rate?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55382/new/

https://reviews.llvm.org/D55382





More information about the cfe-commits mailing list