[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

Thu Dec 6 14:16:23 PST 2018

NoQ added inline comments.

================
Comment at: test/Analysis/diagnostics/explicit-suppression.cpp:22
 #ifndef SUPPRESSED
-  // expected-warning at ../Inputs/system-header-simulator-cxx.h:670 {{Called C++ object pointer is null}}
+  // expected-warning at ../Inputs/system-header-simulator-cxx.h:677 {{Called C++ object pointer is null}}
 #endif
----------------
Szelethus wrote:
> Szelethus wrote:
> > NoQ wrote:
> > > Szelethus wrote:
> > > > Can't we just change this to `// expected-warning{{Called C++ object pointer is null}}`? This file is so tiny, I think it wouldn't cause much confusion, and  reduces unnecessary maintenance work.
> > > I don't think it'll work. The warning is not on this line, it is in `system-header-simulator-cxx.h`, so we need to specify it somehow, and it'll appear only in this test, not in other tests that include that header, so we can't put it directly into the header.
> > Ah, okay.
> Buuuuut since this is the only warning in the file, we could get away with it of we use `FileCheck`! But I leave it up to you.
> 
> I had a lot of bots breaking on me because I forgot `git add` on this file once, so I might end up fixing it myself.
Mmm, maybe. This test is tiny enough.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55307/new/

https://reviews.llvm.org/D55307