[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 6 12:35:44 PST 2018


efriedma added a comment.

> In fact -mllvm is used extensively in a lot of lit/FileCheck tests, so that's also going to cause problems.

I count 13 uses of -mllvm in driver commands in-tree, and some of those are actually testing the flag itself.  That doesn't seem like a lot.  (This is excluding uses in CHECK lines and "clang -cc1" invocations.)

> Possibly you missed that this flag is exempt from -Werror -- it _only_ prints a warning, and is not an error, even when -Werror is specified.

If the warning isn't going to honor -Werror, you might as well not print it at all; for many projects, nobody reads the logs of a successful build.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55150/new/

https://reviews.llvm.org/D55150





More information about the cfe-commits mailing list