[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 6 12:08:14 PST 2018


jyknight added a comment.

In D55150#1321829 <https://reviews.llvm.org/D55150#1321829>, @efriedma wrote:

> I'm not sure that putting a warning that can be disabled really helps here; anyone who needs the option will just disable the warning anyway, and then users adding additional options somewhere else in the build system will miss the warning.
>
> Instead, it would probably be better to rename Xclang and mllvm to something that makes it clear the user is doing something unsupported. Maybe "--unstable-llvm-option" and "--unstable-clang-option" or something like that.  (This will lead to some breakage, but the breakage is roughly equivalent for anyone using -Werror.)


Possibly you missed that this flag is exempt from -Werror -- it _only_ prints a warning, and is not an error, even when -Werror is specified.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55150/new/

https://reviews.llvm.org/D55150





More information about the cfe-commits mailing list