[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 6 10:50:43 PST 2018


thakis added a comment.

I don't have an opinion on this patch (if you force me to have one, I'm weakly in favor), but I agree with the general sentiment. When I told people to not use mllvm and Xclang before, they told me "but if I'm not supposed to use them, why are they advertised in --help"?

  thakis at thakis:~/src/llvm-build$ bin/clang --help | grep Xclang
    -Xclang <arg>           Pass <arg> to the clang compiler
  thakis at thakis:~/src/llvm-build$ bin/clang --help | grep mllvm
    -mllvm <value>          Additional arguments to forward to LLVM's option processing

Which to me is a valid point! Maybe we should remove them from --help or say "internal only, don't usually use" there?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55150/new/

https://reviews.llvm.org/D55150





More information about the cfe-commits mailing list