[PATCH] D41005: Reuse preamble even if an unsaved file does not exist
Nikolai Kosjar via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 6 06:16:20 PST 2018
nik marked 4 inline comments as done.
nik added inline comments.
================
Comment at: include/clang/Frontend/ASTUnit.h:581
+ unsigned getPreambleCounter() const { return PreambleCounter; }
+
----------------
ilya-biryukov wrote:
> NIT: `getPreambleCounterForTests()`? This is clearly an internal detail, would try giving it a name that discourages using it outside the testing code.
Done.
Side note: I hardly see something like this used in clang, but I agree that it's good.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D41005/new/
https://reviews.llvm.org/D41005
More information about the cfe-commits
mailing list