[PATCH] D54014: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 5 13:53:09 PST 2018
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: clang/lib/Sema/SemaDecl.cpp:13181-13182
+ if (!IFace) {
+ if (!IsLambda)
+ PopExpressionEvaluationContext();
return false;
----------------
Adding this pop before each return seems error-prone. Can you do this with an RAII object instead?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54014/new/
https://reviews.llvm.org/D54014
More information about the cfe-commits
mailing list