[PATCH] D55189: Extract TextNodeDumper class

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 5 12:23:12 PST 2018


steveire marked an inline comment as done.
steveire added inline comments.


================
Comment at: lib/AST/ASTDumper.cpp:90
     // Utilities
-    void dumpPointer(const void *Ptr);
-    void dumpSourceRange(SourceRange R);
-    void dumpLocation(SourceLocation Loc);
-    void dumpBareType(QualType T, bool Desugar = true);
-    void dumpType(QualType T);
+    void dumpType(QualType T) { NodeDumper.dumpType(T); }
     void dumpTypeAsChild(QualType T);
----------------
aaron.ballman wrote:
> Another nice cleanup for later would be to replace these call sites with the `NodeDumper.foo()` version. Same for `dumpBareDeclRef()` below.
These methods are called from `AttrDump.inc`. They'll be removed when the commit to port the Attr dumping goes in.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55189/new/

https://reviews.llvm.org/D55189





More information about the cfe-commits mailing list