r347720 - [RISCV] Mark unit tests as "requires: riscv-registered-target"

[Grang, Mandeep Singh via cfe-commits]

Hi Alex,

Sorry, I missed this thread. I guess I was too quick to commit my patch. 
The actual problem seems to be something else due to which 
riscv32-toolchain.c fails on Windows. The fact that upstream bots seem 
to be fine could point to a bug in our internal code. Basically it is 
not able to find riscv32-unknown-elf-ld and ends up invoking ld.exe. I 
will look into this in more detail. Meanwhile I have reverted this patch 
in r348402.

--Mandeep

On 12/5/2018 12:28 AM, Alex Bradbury wrote:
> On Thu, 29 Nov 2018 at 09:44, Alex Bradbury <asb at lowrisc.org> wrote:
>> On Tue, 27 Nov 2018 at 22:56, Mandeep Singh Grang via cfe-commits
>> <cfe-commits at lists.llvm.org> wrote:
>>> Author: mgrang
>>> Date: Tue Nov 27 14:53:57 2018
>>> New Revision: 347720
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=347720&view=rev
>>> Log:
>>> [RISCV] Mark unit tests as "requires: riscv-registered-target"
>>>
>>> Some of these tests break if the RISCV backend has not been built.
>>>
>>> Reland D54816.
>>>
>>> Modified:
>>>      cfe/trunk/test/Driver/riscv-abi.c
>>>      cfe/trunk/test/Driver/riscv-arch.c
>>>      cfe/trunk/test/Driver/riscv-features.c
>>>      cfe/trunk/test/Driver/riscv-gnutools.c
>>>      cfe/trunk/test/Driver/riscv32-toolchain.c
>>>      cfe/trunk/test/Driver/riscv64-toolchain.c
>> Hi Mandeep,
>>
>> Maybe I'm missing something obvious but I'm a bit confused - what in
>> these tests requires that lib/Target/RISCV was built?
>>
>> These tests obviously don't fail on the standard builders for instance.
> Hi Mandeep, any thoughts on the question above?
>
> Thanks,
>
> Alex