[PATCH] D55131: [CTU] Add more lit tests and better error handling

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 5 08:45:33 PST 2018


martong marked an inline comment as done.
martong added inline comments.


================
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:247
 llvm::Expected<const FunctionDecl *>
 CrossTranslationUnitContext::importDefinition(const FunctionDecl *FD) {
   ASTImporter &Importer = getOrCreateASTImporter(FD->getASTContext());
----------------
TODO: add a comment that this function never returns with nullptr on success. And consequently `CrossTranslationUnitContext::getCrossTUDefinition` neither.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55131/new/

https://reviews.llvm.org/D55131





More information about the cfe-commits mailing list