[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 5 08:01:11 PST 2018


aaron.ballman marked 2 inline comments as done.
aaron.ballman added inline comments.


================
Comment at: test/SemaCXX/warn-shadow.cpp:236
   }
+  void F(int B); // Ok, declaration; not definition.
 };
----------------
steveire wrote:
> aaron.ballman wrote:
> > lebedev.ri wrote:
> > > Can you please also add one function with out-of-line definition?
> > Gladly!
> Is this redundant now that you've added `G`?
Sort of. `G` eventually has a body whereas `F` does not -- one of the gates on this logic is a function named `willHaveBody()`, so a bit of redundancy here seems reasonable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55321/new/

https://reviews.llvm.org/D55321





More information about the cfe-commits mailing list