[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

Wed Dec 5 08:00:31 PST 2018

mikael marked an inline comment as done.
mikael added inline comments.

================
Comment at: lib/AST/ItaniumMangle.cpp:1507
+    Qualifiers MethodQuals = Qualifiers::fromCVRUMask(
+        Method->getTypeQualifiers().getCVRUQualifiers());
     // We do not consider restrict a distinguishing attribute for overloading
----------------
rjmccall wrote:
> Anastasia wrote:
> > rjmccall wrote:
> > > You can overload based on the address space, right?  I think it needs to be mangled.
> > Does this refer to our earlier discussion https://reviews.llvm.org/D54862#inline-484509
> > 
> > We don't have a way to qualify methods with an address space yet? I was going to send an RFC to `cfe-dev` for this but if you think it would be ok to go ahead with an implementation, I am happy with it. Either way would it be better to do this in a separate patch?
> I'm fine with delaying implementation on these two issues until a later patch since, as you say, they can't be tested well until we support arbitrary address-space qualifiers.  Please at least leave FIXMEs for them.
I actually did update this, since we can test the mangling of __generic in the test.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54862/new/

https://reviews.llvm.org/D54862