[PATCH] D55280: [CTU] Remove redundant error check
Kristóf Umann via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 4 17:17:02 PST 2018
Szelethus added a comment.
>From what I can see, this patch LGTM, but I lack the experience in the CTU department just yet to give any meaningful feedback.
================
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:147
llvm::Expected<const FunctionDecl *>
CrossTranslationUnitContext::getCrossTUDefinition(const FunctionDecl *FD,
----------------
Would it be worth to add a comment that this function never returns with `nullptr` on success?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55280/new/
https://reviews.llvm.org/D55280
More information about the cfe-commits
mailing list