[PATCH] D55067: [HIP] Fix offset of kernel argument for AMDGPU target

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

In D55067#1318810 <https://reviews.llvm.org/D55067#1318810>, @arsenm wrote:

>


An OpenCL kernel may call another OpenCL kernel. I am wondering how do you pass arguments to the kernel callee.

A simpler solution would be not letting hipSetupArgument specify the offset. Since the kernel metadata contains the alignment info of kernel argument, HIP runtime is able to calculate the offset based on kernel metadata by itself. hipSetupArgument only needs to specify the index of the argument and its size.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55067/new/

https://reviews.llvm.org/D55067