[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Tue Dec 4 10:41:31 PST 2018

Szelethus added a comment.

Thanks for the fix! :)

In D55226#1318853 <https://reviews.llvm.org/D55226#1318853>, @Pierre-vh wrote:

> Hello again! I updated the diff and completely removed the outer if.  Please let me know what you think!

If we're sure that `Target` isn't a `nullptr`, it's fine not to use a defensive check, but I think we definitely should add `assert(Target);` before using it.

================
Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:662

+
   // Issue a warning.
----------------
No need for this newline.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55226/new/

https://reviews.llvm.org/D55226