[PATCH] D55133: [CTU] Add statistics

[Gabor Marton via Phabricator via cfe-commits]

martong added a comment.

>> Sorry, but I don't understand the meaning of some options. Could you please explain what are NumNoUnit and NumNotInOtherTU and what is the difference between them?



> Your point is absolutely true. They are the same, I think at some point some time ago they were different (in our fork), now it is just redundancy. So I removed `NumNoUnit`.

They are the same because in `loadExternalAST` we must return witn a non nullptr value, so it seems like the second check is redundant here:

  if (!ASTUnitOrError) {
    return ASTUnitOrError.takeError();
  }
  ASTUnit *Unit = *ASTUnitOrError;
  if (!Unit)
    return llvm::make_error<IndexError>(
        index_error_code::failed_to_get_external_ast);

I am going to open another patch to fix this.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55133/new/

https://reviews.llvm.org/D55133