[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

Tue Dec 4 06:02:09 PST 2018

Anastasia added inline comments.

================
Comment at: lib/Sema/SemaType.cpp:4816
+        // OpenCLCPlusPlus: A class member function has an address space.
+        if (state.getSema().getLangOpts().OpenCLCPlusPlus &&
+            state.getDeclarator().getContext() ==
----------------
mikael wrote:
> Anastasia wrote:
> > Can this be moved into `deduceOpenCLImplicitAddrSpace`?
> deduceOpenCLImplicitAddrSpace is only wrapping a type with an address space. I also need to make sure the FunctionProtoType gets generated with the address space.
FunctionProtoType is a type too. Does it go into deduceOpenCLImplicitAddrSpace when creating this?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54862/new/

https://reviews.llvm.org/D54862