[PATCH] D54945: This commit adds a chapter about clang-tidy integrations
Alexander Kornienko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 4 04:13:29 PST 2018
alexfh added a comment.
In D54945#1318283 <https://reviews.llvm.org/D54945#1318283>, @MarinaKalashina wrote:
> In D54945#1318278 <https://reviews.llvm.org/D54945#1318278>, @alexfh wrote:
>
> > In D54945#1316251 <https://reviews.llvm.org/D54945#1316251>, @MarinaKalashina wrote:
> >
> > > Fixes:
> > >
> > > - empty line before 'Standalone tool'
> > > - table columns with '+/-' aligned
> > > - line width limited to 80 (except for the table)
> > >
> > > Additions:
> > > - clang-tidy-vs plugin
> > > - Clangd in the intro, the table, and CLion's paragraph
> >
> >
> > Did you forget to add a new file to the patch?
> >
> > Please also include full context into the diff. See https://llvm.org/docs/Phabricator.html
>
>
> Sorry but the new diff was included to the patch.. I can see the updates as Diff 176328. Could you please check and let me know if it does not work? Thank you.
Please see the screenshot. The diff might be reversed (new vs. old) or just wrong. And there's no context (not overly important in this particular patch, but still makes it more convenient to review).
F7647494: Screenshot from 2018-12-04 13-04-11.jpg <https://reviews.llvm.org/F7647494>
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54945/new/
https://reviews.llvm.org/D54945
More information about the cfe-commits
mailing list