[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member
Henry Wong via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 4 04:12:23 PST 2018
MTC added a comment.
Please add more context using the `-U` option, like `git diff -U99999 ...`.
In D55226#1317119 <https://reviews.llvm.org/D55226#1317119>, @Pierre-vh wrote:
> Sadly I'm not experienced enough to think of every case that should pass this check, so I limited myself to just fixing the bug.
> Can't we totally remove the outer if so we allow every `Target` expression that has a `ConstantArrayType` to pass this check?
IMHO, it's fine to remove the outer check!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55226/new/
https://reviews.llvm.org/D55226
More information about the cfe-commits
mailing list