[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 4 03:46:39 PST 2018


alexfh added a comment.

In D54401#1315354 <https://reviews.llvm.org/D54401#1315354>, @NoQ wrote:

> The code looks good, but i vaguely remember that we might accidentally break clang-tidy integration that uses this API to enable/disable specific checkers via `-checks=-analyzer-...`.
>
> *summons @alexfh*


It's hard to tell without trying. Could you build and test clang-tools-extra with this patch? There should be a test for the relevant functionality in clang-tidy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54401/new/

https://reviews.llvm.org/D54401





More information about the cfe-commits mailing list