[PATCH] D55062: [clangd] Partition include graph on auto-index.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 4 00:57:18 PST 2018


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: unittests/clangd/BackgroundIndexTests.cpp:204
+  EXPECT_EQ(ShardSource->Sources->size(), 2U); // A.cc, A.h
+  EXPECT_THAT(
+      ShardSource->Sources->lookup("unittest:///root/A.cc").DirectIncludes,
----------------
NIT: maybe also check the hash of `A.cc` is initialized (the value doesn't matter, probably, just to make sure it's not 0)?


================
Comment at: unittests/clangd/BackgroundIndexTests.cpp:212
+  EXPECT_TRUE(ShardHeader->Sources);
+  EXPECT_EQ(ShardHeader->Sources->size(), 2U); // A.h B.h
+  EXPECT_THAT(
----------------
NIT: maybe add a comma? `A.h, B.h`


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55062/new/

https://reviews.llvm.org/D55062





More information about the cfe-commits mailing list