[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

Mandeep Singh Grang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 3 12:28:58 PST 2018


mgrang added a comment.

In D55229#1317232 <https://reviews.llvm.org/D55229#1317232>, @pcc wrote:

> The reason why it has that name is that it was originally added to support the logic here: http://llvm-cs.pcc.me.uk/tools/clang/lib/CodeGen/CGVTables.cpp#991
>
> It looks like it was later repurposed as a "was /MT passed to the driver" flag when the logic was added to mark runtime functions as dllimport depending on the value of the flag.
>
> It certainly seems to make sense to rename it since the name makes no sense as a driver flag and is now being used for other purposes.


How about calling it -fmsvc-static-link?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55229/new/

https://reviews.llvm.org/D55229





More information about the cfe-commits mailing list