[PATCH] D55188: Extract TextChildDumper class

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 3 08:52:44 PST 2018


steveire marked an inline comment as done.
steveire added inline comments.


================
Comment at: include/clang/AST/ASTDumperUtils.h:96
+
+struct TextChildDumper {
+  raw_ostream &OS;
----------------
steveire wrote:
> aaron.ballman wrote:
> > I'm not sold on the name for this class. It's a bit too generic to understand what it does. How about `ASTDumpLayoutFormatter` (and `ASTDumpNodeFormatter` for the node dumper)?
> I'll rename the class to `ASTTextTreeStructure`.
Or rather, `TextTreeStructure`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55188/new/

https://reviews.llvm.org/D55188





More information about the cfe-commits mailing list