[PATCH] D55139: [clangd] Avoid memory-mapping files on Windows

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.


================
Comment at: clangd/FSProvider.cpp:33
+      return File;
+    return std::unique_ptr<VolatileFile>(
+        new VolatileFile(std::move(std::move(*File))));
----------------
kadircet wrote:
> make_unique?
Unfortunately it doesn't work here - `VolatileFile` is private in this class.


================
Comment at: clangd/FSProvider.cpp:34
+    return std::unique_ptr<VolatileFile>(
+        new VolatileFile(std::move(std::move(*File))));
+  }
----------------
kadircet wrote:
> can we move once ?
We need moar moves!!! xD

Thanks for noticing, fixed.




Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55139/new/

https://reviews.llvm.org/D55139