[PATCH] D55124: [CodeComplete] Cleanup access checking in code completion

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Parse/ParseExprCXX.cpp:248
       // seen a leading '::' or part of a nested-name-specifier.
+      ParsedType ObjectTypeForCompletion = ObjectType;
       ObjectType = nullptr;
----------------
What about first checking for whether we are on code completion point and then assigning nullptr to objecttype?

Also it is not in the scope of this patch but I was wondering why we only trigger completion if we've seen a scope specifier, do you have any idea?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55124/new/

https://reviews.llvm.org/D55124