[PATCH] D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 3 01:25:15 PST 2018


lebedev.ri added inline comments.


================
Comment at: lib/Support/MemoryBuffer.cpp:42
 
+static bool MemoryMappingEnabled = true;
+
----------------
Such global flags are a bad idea in general, and really not great in LLVM's case.
The editor would set it for "it's" llvm, but that will also affect the LLVM that is used by e.g. mesa.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54995/new/

https://reviews.llvm.org/D54995





More information about the cfe-commits mailing list