[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

Joerg Sonnenberger via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 2 11:29:39 PST 2018


joerg added a comment.

Can you split off the pure modernisation changes like new exception or print ? Those are completely non-contentious changes after all. I generally do not like the range and list related changes as many instances are clear regressions for the 2.x case. filter to list comprehension should IMO be a separate change as well, but those are much less problematic and often an improvement in terms of both performance and readability.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55121/new/

https://reviews.llvm.org/D55121





More information about the cfe-commits mailing list