[PATCH] D55129: [CTU] Eliminate race condition in CTU lit tests

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 1 12:30:36 PST 2018


a_sidorin added a comment.

Hi Gabor,
Yes, the `%T` variable is obsolete, but it looks like the Guide recommendations are not entirely fulfilled.



================
Comment at: test/Analysis/ctu-main.cpp:1
-// RUN: mkdir -p %T/ctudir
-// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o %T/ctudir/ctu-other.cpp.ast %S/Inputs/ctu-other.cpp
-// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o %T/ctudir/ctu-chain.cpp.ast %S/Inputs/ctu-chain.cpp
-// RUN: cp %S/Inputs/externalFnMap.txt %T/ctudir/
-// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -analyze -analyzer-checker=core,debug.ExprInspection -analyzer-config experimental-enable-naive-ctu-analysis=true -analyzer-config ctu-dir=%T/ctudir -verify %s
+// RUN: mkdir -p %t/ctudir
+// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o %t/ctudir/ctu-other.cpp.ast %S/Inputs/ctu-other.cpp
----------------
The Testing Infrastructure Guide recommends to use `rm -rf %t && mkdir %t`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55129/new/

https://reviews.llvm.org/D55129





More information about the cfe-commits mailing list