[PATCH] D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list

[Vedant Kumar via Phabricator via cfe-commits]

vsk marked an inline comment as done.
vsk added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:1037
   if (hasExportSymbolDirective(Args)) {
-    addExportedSymbol(CmdArgs, "___llvm_profile_filename");
-    addExportedSymbol(CmdArgs, "___llvm_profile_raw_version");
-    addExportedSymbol(CmdArgs, "_lprofCurFilename");
+    if (needsGCovInstrumentation(Args)) {
+      addExportedSymbol(CmdArgs, "___gcov_flush");
----------------
ributzka wrote:
> Are the symbols mutually exclusive?
Yes, since the runtime is a .a, the gcov-specific symbols aren't pulled in when clang-cov is enabled and vice versa.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55151/new/

https://reviews.llvm.org/D55151