[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

[Zachary Turner via Phabricator via cfe-commits]

zturner added a comment.

We can work around it by reading the whole file, but it looks like a bug in QtCreator to me.  We have the file mapped, but maybe when they open the file to save it, *they* are opening the file without `FILE_SHARE_READ`.  It's a logical thing to do on the surface, because they are probably thinking "we are about to change the contents of the file, so we don't want anyone to be reading it at the same time while we modify it".  But this means their call to `CreateFile()` will fail, because we have the file opened for read, and if they want to open it for exclusive access, it's not possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54995/new/

https://reviews.llvm.org/D54995