[PATCH] D55085: Avoid emitting redundant or unusable directories in DIFile metadata entries

[Adrian Prantl via Phabricator via cfe-commits]

aprantl updated this revision to Diff 176148.
aprantl added a reviewer: davide.
aprantl added a comment.
Herald added subscribers: nhaehnle, jvesely.

Turns out that my patch had an unintended interaction with the backend diagnostics engine. This is an updated version of the patch that also updates the backend diagnostics engine to still emit the same diagnostics as before even with the more efficient DIFile encoding.

The backend diagnostics call back into the frontend to emit nicely formatted diagnostics, but my initial CFE patch broke this mechanism for files with an absolute path. This is now fixed by first looking up the relative path in the FileManager and then falling back to the absolute path, which we construct by joining the DIFile's directory and filename.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55085/new/

https://reviews.llvm.org/D55085

Files:
  include/llvm/IR/DiagnosticInfo.h
  lib/CodeGen/MachineLoopInfo.cpp
  lib/IR/DiagnosticInfo.cpp
  test/CodeGen/AMDGPU/vi-removed-intrinsics.ll
  tools/clang/lib/CodeGen/CGDebugInfo.cpp
  tools/clang/lib/CodeGen/CodeGenAction.cpp
  tools/clang/test/CodeGen/debug-info-abspath.c
  tools/clang/test/CodeGen/debug-prefix-map.c
  tools/clang/test/Modules/module-debuginfo-prefix.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55085.176148.patch
Type: text/x-patch
Size: 12773 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181130/e1aa0d90/attachment.bin>