[PATCH] D55069: Extend the CommentVisitor with parameter types

[Stephen Kelly via Phabricator via cfe-commits]

steveire added a comment.

> Huh, that's surprising. It's a perfect forwarding reference

It's not a forwarding reference because the template parameter is from the record, not the function. See

https://godbolt.org/z/L4N2aS

> One of the reasons I think this may be important is with the JSON dumper -- it may pass around JSON values rather than references and rely on move semantics to make this work.

I don't know what you're planning so I can't imagine what you want to pass through these visit function parameters. It would be surprising to me if you used this feature of the visitor for json dumping.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55069/new/

https://reviews.llvm.org/D55069