[clang-tools-extra] r347968 - [clangd] Fix junk output in clangd vscode plugin
Haojian Wu via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 30 01:14:53 PST 2018
Author: hokein
Date: Fri Nov 30 01:14:52 2018
New Revision: 347968
URL: http://llvm.org/viewvc/llvm-project?rev=347968&view=rev
Log:
[clangd] Fix junk output in clangd vscode plugin
Summary:
When using the vscode clangd plugin, lots and lots of junk output is printed to the output window, which constantly reopens itself.
Example output:
I[11:13:17.733] <-- textDocument/codeAction(4)
I[11:13:17.733] --> reply:textDocument/codeAction(4) 0 ms
I[11:13:17.937] <-- textDocument/codeAction(5)
I[11:13:17.937] --> reply:textDocument/codeAction(5) 0 ms
I[11:13:18.557] <-- textDocument/hover(6)
I[11:13:18.606] --> reply:textDocument/hover(6) 48 ms
This should prevent that from happening.
Patch by James Findley!
Reviewers: ioeric, ilya-biryukov, hokein
Reviewed By: ioeric
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D55052
Modified:
clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts
Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts?rev=347968&r1=347967&r2=347968&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts (original)
+++ clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts Fri Nov 30 01:14:52 2018
@@ -54,7 +54,9 @@ export function activate(context: vscode
code2Protocol: (value: vscode.Uri) => value.toString(),
protocol2Code: (value: string) =>
vscode.Uri.file(realpathSync(vscode.Uri.parse(value).fsPath))
- }
+ },
+ // Do not switch to output window when clangd returns output
+ revealOutputChannelOn: vscodelc.RevealOutputChannelOn.Never
};
const clangdClient = new vscodelc.LanguageClient('Clang Language Server', serverOptions, clientOptions);
More information about the cfe-commits
mailing list