[PATCH] D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 29 18:33:32 PST 2018


bruno added a comment.

Thanks for working on this @andrewjcg

In D51568#1313717 <https://reviews.llvm.org/D51568#1313717>, @rsmith wrote:

> I'm also not convinced we need to put this behind a flag. It would seem reasonable to me to simply always emit the `MODULE_DIRECTORY` as relative (if we found the module via a relative path), at least for an explicitly-built module. (For an implicitly built module, we probably need to track the absolute path so we can detect whether we found the right PCM file.)


+1


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51568/new/

https://reviews.llvm.org/D51568





More information about the cfe-commits mailing list