[PATCH] D55069: Extend the CommentVisitor with parameter types
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 29 12:26:12 PST 2018
aaron.ballman added a comment.
Overall this seems reasonable, but this change is currently a no-op because nothing is using this -- what's the plan for using and testing these changes?
================
Comment at: include/clang/AST/CommentVisitor.h:31
- RetTy Visit(PTR(Comment) C) {
+ RetTy Visit(PTR(Comment) C, ParamTys... P) {
if (!C)
----------------
Should this be `ParamTys&&...` because we're forwarding in the actual call? (Similar below)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55069/new/
https://reviews.llvm.org/D55069
More information about the cfe-commits
mailing list