[PATCH] D55052: Fix junk output in clangd vscode plugin

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 29 06:30:06 PST 2018


ilya-biryukov added a comment.

+1 to the change, this is annoying for me too.

In D55052#1312753 <https://reviews.llvm.org/D55052#1312753>, @hokein wrote:

> @jfindley I'd like to understand how do these log messages noise you? Does the window prompt up to you automatically (this only happens when there is an error in clangd)? These messages only get print to the  `clangd-vscode` output panel which is used for debugging purposes (normal users won't open this window by their own).


It's fine to have this open for debugging purposes, the real problem is that it pops up whenever clangd send an error response. We do this a lot now that we support cancellation and the default policy is to show an output window in that case as well.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55052/new/

https://reviews.llvm.org/D55052





More information about the cfe-commits mailing list