[PATCH] D54872: [clangd] Add ability to not use -resource-dir at all

[Marc-Andre Laperle via Phabricator via cfe-commits]

malaperle added a comment.

Reading D54630 <https://reviews.llvm.org/D54630>, I think that's what might be happening. Here's how to reproduce the problem though:

- Clangd compiled from source with Visual Studio 2017 (i.e. not from win installer)
- LLVM win installer from http://llvm.org/builds/

d:\dev\experiments\resource-dir-problem\test.cpp:

  #include <exception>

D:\dev\experiments\resource-dir-problem\compile_commands.json:

  [
    {
      "file": "D:\\dev\\experiments\\resource-dir-problem\\test.cpp",
      "directory": "D:\\dev\\experiments\\resource-dir-problem",
      "command": "cl /c /c test.cpp /std:c++14 /imsvc\"C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Professional\\VC\\Tools\\MSVC\\14.15.26726\\include\" /imsvc\"C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Professional\\VC\\Tools\\MSVC\\14.15.26726\\atlmfc\\include\" /I\"C:\\Program Files\\LLVM\\lib\\clang\\8.0.0\\include\" -m64 -fmsc-version=1910"
    }
  ]

Resulting log:

   Updating file d:\dev\experiments\resource-dir-problem\test.cpp with command [D:\dev\experiments\resource-dir-problem] cl /c /c test.cpp /std:c++14 /imsvcC:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.15.26726\include /imsvcC:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.15.26726\atlmfc\include /IC:\Program Files\LLVM\lib\clang\8.0.0\include -m64 -fmsc-version=1910 -resource-dir=D:\git\llvm\build-vs2017\RelWithDebInfo\bin\..\lib\clang\8.0.0
  I[23:39:49.389] <-- textDocument/codeAction(1)
  I[23:39:49.389] --> reply:textDocument/codeAction(1) 0 ms
  I[23:39:49.481] Dropped diagnostic outside main file: C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.15.26726\include\vcruntime.h: unknown type name 'uintptr_t'; did you mean 'intptr_t'?
  ... some more errors after


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54872/new/

https://reviews.llvm.org/D54872