[PATCH] D53280: [analyzer] Emit an error for invalid -analyzer-config inputs

Wed Nov 28 15:12:26 PST 2018

Szelethus marked 2 inline comments as done.
Szelethus added inline comments.

================
Comment at: lib/Driver/ToolChains/Clang.cpp:2348
+  // Enable compatilibily mode to avoid analyzer-config related errors.
+  CmdArgs.push_back("-analyzer-config-compatibility-mode=true");
+
----------------
xazax.hun wrote:
> I wonder if it makes more sense to not add this here but rather make the default option to be true.
We resolved this IRL, but just for the record, this line will run when the analyzer is invoked with `--analyze` (essentially, in driver mode), in which case we wouldn't like to receive errors on invalid input, but with `-cc1` (frontend mode), it will be disabled by default .

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53280/new/

https://reviews.llvm.org/D53280