[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 28 08:21:34 PST 2018
Anastasia marked 2 inline comments as done.
Anastasia added inline comments.
================
Comment at: lib/Sema/TreeTransform.h:5276
+ // Return type cann't be qualified with an address space.
+ if (ResultType.getAddressSpace() != LangAS::Default) {
----------------
bader wrote:
> "cann't" - typo?
> cann't - > can't or cannot.
Thanks!
================
Comment at: test/CodeGenOpenCLCXX/template-address-spaces.cl:28
sintptrgl.foo();
//sintgl.foo();
}
----------------
bader wrote:
> I think it should comment should also be removed.
Good spot!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54858/new/
https://reviews.llvm.org/D54858
More information about the cfe-commits
mailing list