[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

[Ilya Biryukov via cfe-commits]

I don't have a Windows machine, but I tried it on the VM and couldn't come
up with a combination of flags that breaks it.
Which is weird because the linked stackoverflow question mentions Windows
locks all files on mmap, but that's not what I was seeing.

I'll repeat the experiment.


On Wed, Nov 28, 2018 at 4:40 PM Zachary Turner <zturner at google.com> wrote:

> Do you all have Windows machines? The easiest thing to do is just write a
> sample program that mmaps a file and then tries to delete it, iterating
> over every possible set of flags.
> On Wed, Nov 28, 2018 at 7:25 AM Ivan Donchevskii via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> yvvan added a comment.
>>
>> @ilya-biryukov
>>
>> According to https://stackoverflow.com/a/7414798 (if it's true) we can't
>> prevent locks.
>>
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D54995/new/
>>
>> https://reviews.llvm.org/D54995
>>
>>
>>
>>

-- 
Regards,
Ilya Biryukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181128/41441975/attachment.html>