[PATCH] D54903: [Sema] Improve static_assert diagnostics.
Clement Courbet via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 28 05:09:38 PST 2018
courbet added inline comments.
================
Comment at: lib/Sema/SemaTemplate.cpp:3076
+ return false;
+ const RecordDecl * Record = NNS->getAsRecordDecl();
+ // In namespace "::std".
----------------
aaron.ballman wrote:
> Formatting is incorrect here; you should run the patch through clang-format.
>
> Can `getAsRecordDecl()` return null even when looking for a type out of a NNS? If so, you should assert/test for that.
Good point, I've added a test.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54903/new/
https://reviews.llvm.org/D54903
More information about the cfe-commits
mailing list