[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

Ivan Donchevskii via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 28 01:38:41 PST 2018


yvvan added a comment.

@ilya-biryukov

I have the reported evidence but didn't yet have time to investigate myself.
This is probably caused by our upgrade to Clang-7 which shows that we can't rely on the aimed fixes like the one I mention (D47460 <https://reviews.llvm.org/D47460>).

Another option that I can suggest here is to remove all default isVolatile values at all, track all callers and specify the proper value in each case (ideally depending on the current flags). What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54995/new/

https://reviews.llvm.org/D54995





More information about the cfe-commits mailing list