[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

Victor Costan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 27 11:08:46 PST 2018


pwnall added a comment.

In D52578#1307145 <https://reviews.llvm.org/D52578#1307145>, @aaronpuchert wrote:

> To be clear, I'm not a big fan of this change myself, I just wanted to see if it was feasible. My personal opinion, as I wrote in the bug report, is that scoped releasing of mutexes is taking RAII a step too far. I'm putting this on ice for now until we're reached a state where it looks a bit less crazy. I hope @pwnall can live with that, since Clang 8 will not come out soon anyway.


If it makes a difference, Chrome (loosely) tracks Clang trunk <https://cs.chromium.org/chromium/src/tools/clang/scripts/update.py?q=CLANG_REVISION&l=30>. We wouldn't wait for a stable release to adopt the new code.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52578/new/

https://reviews.llvm.org/D52578





More information about the cfe-commits mailing list