[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 27 01:35:41 PST 2018


ilya-biryukov added a comment.

In D54630#1308671 <https://reviews.llvm.org/D54630#1308671>, @dexonsmith wrote:

> I'm a little skeptical that splitting this logic between cc1 and the driver will simplify things, but I haven't looked in detail and I'll defer to your (collective) judgement.


Most of the toolchain search logic is in the driver, so moving from the frontend to the driver is actually a step in moving the logic into one place.

In D54630#1308605 <https://reviews.llvm.org/D54630#1308605>, @arphaman wrote:

> @ilya-biryukov I'm going to do some internal testing to see if we uncover any issues.


Many thanks, will be waiting for the results of the internal testing.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54630/new/

https://reviews.llvm.org/D54630





More information about the cfe-commits mailing list