[PATCH] D54900: [Sema] Avoid CallExpr::setNumArgs in Sema::BuildCallToObjectOfClassType
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 26 13:09:05 PST 2018
aaron.ballman added inline comments.
================
Comment at: lib/Sema/SemaOverload.cpp:13260
+ // The number of arguments slots to allocate in the call.
+ // If we have default arguments we need to allocate space for them
----------------
arguments -> argument
Also, I think this comment can be re-flowed to condense it.
================
Comment at: lib/Sema/SemaOverload.cpp:13308
- TheCall->setArg(i + 1, Arg);
+ MethodArgs[i+1] = Arg;
}
----------------
Formatting is off here.
================
Comment at: lib/Sema/SemaOverload.cpp:13318
IsError |= Arg.isInvalid();
- TheCall->setArg(i + 1, Arg.get());
+ MethodArgs[i+1] = Arg.get();
}
----------------
Here as well.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54900/new/
https://reviews.llvm.org/D54900
More information about the cfe-commits
mailing list