[PATCH] D54894: [clangd] Enable auto-index behind a flag.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 26 07:39:41 PST 2018


sammccall marked an inline comment as done.
sammccall added inline comments.


================
Comment at: test/clangd/background-index.test:16
+# Test that the index is writing files in the expected location.
+# RUN: ls %t/.clangd-index/foo.cpp.*.idx
+
----------------
kadircet wrote:
> kadircet wrote:
> > and this
> also I suppose we might wanna delete this file after test ends(if the temp directory is not already deleted at exit)
Convention is that tests are responsible for cleaning up the temp directory *before* they run, but not after.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54894/new/

https://reviews.llvm.org/D54894





More information about the cfe-commits mailing list